Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from WebKit to WebKit2 #28

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Port from WebKit to WebKit2 #28

merged 1 commit into from
Nov 1, 2018

Conversation

tonadev
Copy link
Contributor

@tonadev tonadev commented Nov 1, 2018

Explanation

Fix #27. This PR ports from WebKit to WebKit2.

Reason

The WebKit API version 3.0 is deprecated and activities still using it throws a lot of PyGI errors, port this activity to the WebKit2 4.0 API.

TODO

  • Test (Don't know how to finish login, it asks me to copy a code that gmail gives me to the application, but I have no idea where to copy it).

@quozl
Copy link
Contributor

quozl commented Nov 1, 2018

Thanks. Reviewed. As it doesn't matter to me if this activity is working, I'll merge without testing. Plenty of other issues listed with the activity.

@quozl quozl merged commit e52021c into sugarlabs:master Nov 1, 2018
@tonadev tonadev deleted the port-from-webkit-to-webkit2 branch November 4, 2018 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants