Port scale.py to TypeScript #24

meganindya · 2021-03-19T21:06:58Z

Addresses #18.

Add interface IScale for class Scale in scale.d.ts
Port class Scale and all its members in scale.py to scale.ts
Add important unit tests re members of the Scale class in scale.test.ts

Test verification:

Todo:

Exhaustively implement remaining test cases for the Scale class.

This commit creates an interface IScale for the public members of the Scale class that is to be implemented.

Create the Scale class that implements the IScale interface created previously. Add documentation.

Create unit tests to verify the crucial public member methods of the Scale class. Error cases not verified.

meganindya added 3 commits March 20, 2021 02:28

feat: add interface for Scale class

4e8911f

This commit creates an interface IScale for the public members of the Scale class that is to be implemented.

feat: add Scale class implementation

19f9b51

Create the Scale class that implements the IScale interface created previously. Add documentation.

test: add unit tests for the Scale class

ff056a2

Create unit tests to verify the crucial public member methods of the Scale class. Error cases not verified.

meganindya merged commit 3e94ca5 into musicutils Mar 19, 2021

meganindya deleted the 18-port-scale branch March 19, 2021 21:09

This was referenced Mar 19, 2021

Port musicutils prototype code from Python to TypeScript #18

Closed

Ported scale.py to scale.ts with unit test cases #20

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port scale.py to TypeScript #24

Port scale.py to TypeScript #24

meganindya commented Mar 19, 2021 •

edited

Loading

Port scale.py to TypeScript #24

Port scale.py to TypeScript #24

Conversation

meganindya commented Mar 19, 2021 • edited Loading

meganindya commented Mar 19, 2021 •

edited

Loading