Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port musicutils.py to TypeScript #28

Merged
merged 2 commits into from
Mar 20, 2021
Merged

Port musicutils.py to TypeScript #28

merged 2 commits into from
Mar 20, 2021

Conversation

meganindya
Copy link
Member

Addresses #18.

Modified from #27. Reworked on the commits by cherry picking and interactive rebasing.

  • Port contents of musicutils.py to musicutils.ts
  • Add unit tests in musicutils.test.ts re utility functions in musicutils.ts

Test verification:
Screenshot 2021-03-20 at 6 07 33 PM

Todo:

  • Add missing error test cases

@meganindya
feat: port the contents of musicutils.py
52f2cfc 
Constants are not documented.
@meganindya
test: add unit tests for music utility functions
c2fceca 
Couple of Error cases not tested.
@meganindya meganindya merged commit 68a5086 into musicutils Mar 20, 2021
@meganindya meganindya deleted the 18-port-musicutils branch March 20, 2021 12:51
This was referenced Mar 20, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@meganindya