Port to python3

[ayushnawal]

Tested.
All set.

[Aniket21mathur]

Thanks. Reviewed. No comments.

[ayushnawal]

@quozl please review!

[quozl]

Thanks, but given your other pull requests involving the Sugargame API, I'd prefer to see you fix them before I review any further changes.

[ayushnawal]

I reviewed and fixed them as you suggested, you can review these changes now

[srevinsaju]

Thanks @ayushnawal
Tested,

• Activity does not terminate properly. This creates an everrunning background process similar to Conzoco activities. On trying to force kill the activiity (ctrl+c) , it creates a LookupError regarding dbus.

found some general bugs that might not have arisen due to porting but, yeah:

• Unable to press / interact with stop button when the countdown goes on. (this might not be an important bug, but of general notice)

[quozl]

* Activity does not terminate properly.

Possibly because the stop button does not have a callback that signals the event loop to terminate.

See the Sugargame test activity for how to do this.

[ayushnawal]

Terminating for me properly now.

@srevinsaju @quozl please review

[srevinsaju]

Thanks @ayushnawal, the error's fixed.

[quozl]

Thanks Reviewed as at 240e47c.

• variable naming; crashed usually means failure, and a request to stop is not a failure; consider the name as used by the Sugargame test activity,
• although the stop button or accelerator may be used, the three event loops complete a display update and clock delay before returning; it is better to return as soon as the activity is asked to stop,
• setup.py is still Python 2,
• NumRush.py still begins with a Python version independent hash bang,
• README.md refers to Numberrush, but the name of the activity in activity.info and elsewhere is different.

Hope that helps. I didn't have time for a full review.

[ayushnawal]

Fixes done as suggested. Please review @quozl

README.md refers to Numberrush, but the name of the activity in activity.info and elsewhere is different.

I looked at activities.sugarlabs.org , named it as it was there.

[quozl]

Thanks. Reviewed again.

• the ctrl+q accelerator or stop button does not work during the newGameAnimation, because the GTK event source is not being pumped; Sugar pygame activities can't use pygame.time.wait for this reason; instead delays have to be implemented by running the event loop until a time has expired, as I mentioned in another pull request.

[quozl]

Ah, there it is. My comment there shows how to solve the above problem and keep the game user experience the same.

[ayushnawal]

Fixed it also 😁

Thanks for the help

Tried to improve code quality, removed repetitive code using a function

Tested. all changes are done.

Please review

[quozl]

You are yet to

• run the event loop until a time has expired, as I mentioned in Python 3 triples#7 (comment).

As the code stands now, ctrl+q is ignored during each call to pygame.time.wait.

[ayushnawal]

Fixed. optimized.

@quozl, please review

[quozl]

Thanks. Heavy CPU usage during numGameAnimation, please fix.

[ayushnawal]

Thanks, Fixed it 😁

verified using htop

@quozl

[quozl]

Thanks. Tested.

• the high score is not kept from one instance to the next; in reviewing this activity on 2018-01-29 it was said "make sure that stopping and resuming the activity returns to the same game state; this is what read_file and write_file are for", but other activities use a file in the instance directory for keeping a high score,
• the box can be moved off the right edge by pressing the right arrow key repeatedly,
• the falling speed of the numbers increases in a step-wise fashion as the game progresses, and the steps seem large,
• when using the non-activity mode (python3 NumRush.py) the window has a window manager border which causes the box to be invisible.

https://github.com/Gr33nMayhem/NumberRush/issues has some other issues yet to be worked on.

[JuiP]

@ayushnawal ping

[srevinsaju]

@JuiP , seems like we lost the push on this PR. If you would like to continue this PR, then you may do it.

[sourabhaa]

@srevinsaju @quozl @chimosky I'm interested to complete this PR. I cloned it in Activities directory, but I'm not able to run the activity from the homepage. The activity icon doesn't show up on home page. Am I missing anything?

[quozl]

That is because as at 7eeaaef ("update sugargame to v1 .3") activity/activity.info exec is not yet ported. There's also a missing end of line mark in the file, and my shell prompt is misplaced after I used cat. ;-)

[chimosky]

@srevinsaju @quozl @chimosky I'm interested to complete this PR. I cloned it in Activities directory, but I'm not able to run the activity from the homepage. The activity icon doesn't show up on home page. Am I missing anything?

Thanks for picking this up, what's left is mentioned in #1 (comment) and while looking at the other repo, you can keep the flake8 fixes to a different PR.