Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #44 . Adds charging icon to charging battery sign #22

Merged
merged 1 commit into from Jan 8, 2014
Merged

Fixes #44 . Adds charging icon to charging battery sign #22

merged 1 commit into from Jan 8, 2014

Conversation

ghost
Copy link

@ghost ghost commented Nov 25, 2013

Adds charging battery icon to charging battery size. Fill has been removed leaving only battery and Z badge stroke.

@dnarvaez
Copy link
Contributor

@manuq could you take another look please?

@manuq
Copy link
Contributor

manuq commented Jan 8, 2014

Nice, it works now. The only thing that doesn't work is the fill of the icon when the charge is at 100%. I'll take care of that.

The only other pending thing is remove the monochrome. I sent a new pull request for that.
sugarlabs/sugar#193

Looking at the shell code I found that we also add a warning badge to this button when the battery charge is under _WARN_MIN_PERCENTAGE in extensions/deviceicon/battery.py. Found that the result with these new icons is not worse than before. So let's go with them!

Also noticed that this could have been resolved with a badge, but I'm fine with this solution. The badges are usually be bad placed.

For future, please add a link to the previous pull request when you send a new try. That way we don't lose the previous feedback.

Thanks!

@manuq manuq merged commit 3477420 into sugarlabs:master Jan 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants