Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate treeview row styling for Gtk+ version, fixes #4855 #75

Merged

Conversation

samdroid-apps
Copy link
Contributor

The older Gtk+ treeview css make the treeviews background single
colored on newer Gtk+. This patch discovers the Gtk+ version
through pkg-config as to introduce no new deps.

Ticket https://bugs.sugarlabs.org/ticket/4855

Replaces #74

The older Gtk+ treeview css make the treeviews background single
colored on newer Gtk+.  This patch discovers the Gtk+ version
through pkg-config as to introduce no new deps.

Ticket <https://bugs.sugarlabs.org/ticket/4855>
@samdroid-apps samdroid-apps added this to the 0.108 milestone Oct 9, 2015
@i5o
Copy link
Contributor

i5o commented Oct 9, 2015

Tested on sugar-build, broot mode.

[osbuild sugar-build]$ pkg-config --modversion gtk+-3.0
3.10.9
[osbuild sugar-build]$ lsb_release -a
LSB Version: :core-4.1-ia32:core-4.1-noarch
Distributor ID: Fedora
Description: Fedora release 20 (Heisenbug)
Release: 20
Codename: Heisenbug
[osbuild sugar-build]$

Doesn't broke the current model.
Will test ASAP on Fedora rawhide with mode_none

@i5o
Copy link
Contributor

i5o commented Oct 10, 2015

Tested on:

[ignacio@ignacio-pc ~] $ pkg-config --modversion gtk+-3.0
3.18.1
[ignacio@ignacio-pc ~] $ lsb_release -a
LSB Version:    :core-4.1-ia32:core-4.1-noarch:cxx-4.1-ia32:cxx-4.1-noarch:desktop-4.1-ia32:desktop-4.1-noarch:languages-4.1-ia32:languages-4.1-noarch:printing-4.1-ia32:printing-4.1-noarch
Distributor ID: Fedora
Description:    Fedora release 23 (Twenty Three)
Release:    23
Codename:   TwentyThree
[ignacio@ignacio-pc ~] $ 

Three test cases:
ListView, Treeview on Log activity, Journal activity.

patch not applied:
journal without patch
listview without patch
log without patch

Patch applied:
journal with patch
listview with patch
log with patch

i5o added a commit that referenced this pull request Oct 10, 2015
…gain-again

Use appropriate treeview row styling for Gtk+ version, fixes #4855
@i5o i5o merged commit b887ab2 into sugarlabs:master Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants