Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Six { Ongoing } #385

Closed
wants to merge 2 commits into from
Closed

Port to Six { Ongoing } #385

wants to merge 2 commits into from

Conversation

anmol27katyani
Copy link

@anmol27katyani anmol27katyani commented Mar 9, 2018

Progress goals under evaluation for #382 :

  • fix a critical accidental dependency; remove the from jarabe.model import shell from src/sugar3/graphics/popwindow.py and use some other design,
  • port toolkit code in src/sugar3 which calls C code, and test that the C code can be called from REPL,
  • port toolkit code in src/sugar3/graphics,
  • port graphics examples
  • examples are tested
  • Include old files with .bak for Backup
  • port toolkit code in src/sugar3/activity,
  • regenerate documentation,
  • port make files, and test that "make install" installs both bindings,
  • make local Fedora and Debian packages for testing by others.

@quozl
Copy link
Contributor

quozl commented Mar 9, 2018

#383 has already ported some of these files; I don't know how your changes fit together with those ones.

Were the tests run with python3? If not, you'll need other changes from #383.

Don't make .bak files, they make it impractical to review the changes in a pull request, and the old files are always available in git.

@rhl-bthr
Copy link

rhl-bthr commented Mar 9, 2018

@octamois, the changes in this PR seem repititive
#383 already has all the changes, tested with Python3.

@quozl quozl mentioned this pull request Mar 9, 2018
13 tasks
@quozl
Copy link
Contributor

quozl commented Mar 9, 2018

See my comment in issue #382.

@anmol27katyani
Copy link
Author

@quozl noted
I saw that #383 was not merged, I will follow the prescribed method to avoid redundancy in upcoming stages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants