[Feature] Color coded devices. #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiki.laptop.org, where the pages used to update the activities are located, usually serve old cached pages. We can avoid that setting the header Cache-Control' = 'max-age=600', and be sure the page is not older than 10 minutes. A reason to set this at client side, and not solve it only in wiki.laptop.org, is the posibility of intermnediate caches, as provider or school server proxies, or the use of other activities servers in particular deployments. Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
The object_id can be retrieved in more than one chunk, then the parser should take carr of that. Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
Without this patch, the updater show a message 'Your software is up-to-date', when can't connect to the server. Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
Updates LGPL-python.txt to read the FSF's new address.
…unning01-patch-2
This is needed to allow the next update request to work. This was missed in the last patch "Show a error message if the activity updater can't connect to the server" Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
If the user changes the username on My Setting -> About me view and then reverts it to the initial username, remove the warning about restart.
Take into consideration also the following usecases: - user also changes the color - user cancels the modifications and reverts to the initial username - user makes a change, reverts, clicks accept, reenters the About Me settings
This patch finally set a UNIQUE color for UNIQUE device. Because the uuid never is the same in the devices. If not uuid, this use the path.
|
Remember the idea of this feature is to identify a external device its color. If the color of one external device changes (ie., between machines as in the example I showed you, or even if you connect two devices with the same characteristics, as I explain above), then it fails because it lacks the "identity" property, which is the basis for identifying something. If you connect a external device, while another is connected, and you get RED, but then you re-connect the same device without, when the other device is gone, and you get BLUE, then its wrong. Because the color is not identifying it anymore. |
|
Sounds like this needs work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch finally set a UNIQUE color for UNIQUE device.
Because the uuid never is the same in the devices.
If not uuid, this use the path.