Session2 #90
Closed
Session2 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2013 09:35
Fixes #4611 . SessionManager now sends a stop signal in each logout, shutdown or reboot. Apisocket connects to this signal to send the stop message to web activities, so they can do cleanup and store. SessionManager now uses the ShellModel to check if all activities have been removed. If not, it tries again after one second for ten times. After that, it forces shutdown. SessionManager has been moved completly to the shell. It was inheriting a counterpart class in the toolkit, but was the only consumer of that class. Journal is a special case. It will not be destroyed automatically like other activities. So we connect it to the SessionManager stop signal and destroy it in the callback.
The previous commit destroys the Journal window in session logout. Sugar was assuming that there was always one active activity. But now it can be None.
|
Pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.