Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use focus-in/out events to set the visibility in the journal - SL# 4604 #96

Closed
wants to merge 1 commit into from
Closed

Conversation

godiard
Copy link
Contributor

@godiard godiard commented Sep 5, 2013

The callback method of the signal 'visibility-notify-event' receive
event.get_state() == None in the case of changing from the Journal to
another activity, but not when changing to other views using F1, F2, F3.
Use focus-in/focus-out events to set the visibility of the listview,
because this works with realibility.

Signed-off-by: Gonzalo Odiard gonzalo@laptop.org

The callback method of the signal 'visibility-notify-event' receive
event.get_state() == None in the case of changing from the Journal to
another activity, but not when changing to other views using F1, F2, F3.
Use focus-in/focus-out events to set the visibility of the listview,
because this works with realibility.

Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
@manuq
Copy link
Contributor

manuq commented Sep 5, 2013

The question is, why the journal doesn't reach Gdk.VisibilityState.FULLY_OBSCURED when the user switches to the shell views?

I'm trying to investigate this.

@manuq
Copy link
Contributor

manuq commented Sep 5, 2013

Another option could be, consider state PARTIAL as non visible:

-       visible = event.get_state() != Gdk.VisibilityState.FULLY_OBSCURED
+       visible = event.get_state() == Gdk.VisibilityState.UNOBSCURED

@godiard godiard closed this Sep 5, 2013
@godiard godiard deleted the fix#4604 branch November 18, 2013 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants