Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trustworthy related warning on ghc-7.10 #34

Closed
qnikst opened this issue Jan 28, 2015 · 0 comments · Fixed by #47
Closed

Trustworthy related warning on ghc-7.10 #34

qnikst opened this issue Jan 28, 2015 · 0 comments · Fixed by #47
Assignees
@suhailshergill

Comments

@qnikst
Copy link
Contributor

qnikst commented Jan 28, 2015

If compat/ghc-7.10 branch is build on ghc 7.10 there are a bunch of warnings:

on the commandline: Warning:
    `Control.Eff.Writer.Strict' is marked as Trustworthy but has been inferred as safe!

This happens because starting from 7.10 ghc checks if module is more safe than it's marked.
The problem here is that there is no obvious simple solution for the case when Trustworthy is set in default-extenstion, because adding {-# LANGUAGE Safe #-} will conflict with Trustworthy and there is no NoTrustworthy pragma to disable Trustworthy.

As a solution I'd suggest removing Trustworthy from default-extensions and set it only in relevant modules.
@suhailshergill suhailshergill self-assigned this Jan 28, 2015
@suhailshergill suhailshergill mentioned this issue Jan 29, 2015
Closed
@rrnewton rrnewton mentioned this issue May 11, 2015
Closed
@suhailshergill suhailshergill mentioned this issue May 12, 2015
Merged
1 task
suhailshergill added a commit that referenced this issue May 12, 2015
@suhailshergill
compat/ghc-7.10: use Safe instead of Trustworthy
f8b4e33 
use the less powerful -XDeriveFunctor for Control.Eff.Fresh and thereby
use Safe as he default-extension.

fixes #34.
suhailshergill added a commit that referenced this issue May 12, 2015
@suhailshergill
compat/ghc-7.10: use Safe instead of Trustworthy
bb38134 
use the less powerful -XDeriveFunctor for Control.Eff.Fresh and thereby
use Safe as the default-extension.

fixes #34.
suhailshergill added a commit that referenced this issue May 12, 2015
@suhailshergill
compat/ghc-7.10: fix compiler warnings
377ee16 
- deal with warnings as a result of AMP
- use ticks to denote promoted data constructors such as 'True

compat/ghc-7.10: expose Data.OpenUnion.Imports

compat/ghc-7.10: fix: use Trustworthy selectively

in ghc < 7.8 we have to write a Typeable instances for Control.Eff.Lift
and Control.Eff.Operational by hand, this makes them Trustworthy instead
of Safe.

fixes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suhailshergill suhailshergill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compat/ghc 7.10: support ghc 7.10 suhailshergill/extensible-effects
2 participants
@qnikst @suhailshergill