Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should all components be namespaced? #19

Closed
necolas opened this issue May 29, 2013 · 3 comments
Closed

Should all components be namespaced? #19

necolas opened this issue May 29, 2013 · 3 comments

Comments

@necolas
Copy link
Contributor

necolas commented May 29, 2013

See original plan in #8

I think I ended up wanting SUIT components to seamlessly blend into application code, but there might be some benefit to using the suit- prefix.

@jaredhanson
Copy link
Contributor

I'm in favor of no suit- prefix for the core SUIT components. Since SUIT forms the foundational layer of a project, I think it has the right to claim the "root" namespace. Non-core stuff built on top should namespace itself as necessary.

I've also been toying with the idea of a more Cocoa-esque namespacing method, where you'd pick a two or three capitalized letters to denote your custom components. For example:

JHTableView
JHTableView--mini

My two cents.

@necolas
Copy link
Contributor Author

necolas commented Aug 21, 2013

I'm not convinced of the readability of names like TWTTweet over than twt-Tweet.

There's also an intentional nod to the current requirement for Web Component custom elements: that the tag name must contain a hyphen. But, I'm ok with the components provided by the core SUIT framework not being namespaced. There aren't many of them and it leaves people to build up their application's components (namespaced) following the same methodology.

@necolas
Copy link
Contributor Author

necolas commented Aug 28, 2013

Since SUIT forms the foundational layer of a project, I think it has the right to claim the "root" namespace.

Yeah I think I'll go with this for now. The framework comes with some generic components but they don't have to be used.

@necolas necolas closed this as completed Aug 28, 2013
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants