Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable tabs, no js appearance, and content jump #4

Closed
necolas opened this issue Nov 22, 2011 · 3 comments
Closed

Reusable tabs, no js appearance, and content jump #4

necolas opened this issue Nov 22, 2011 · 3 comments

Comments

@necolas
Copy link
Contributor

necolas commented Nov 22, 2011

Some issues with the tabs that need to be considered:

  • Styling of content without JS. At the moment you cannot see any tabs other than the first one when JS is disabled. They should all be visible by default.
  • Content jumping. When you click on one of the tabs, the viewport jumps up sometimes as the content is hidden/show.
  • Reusable tab component. The style of the tabs themselves should be independent of the js tabs because you might want to use them for main navigation too. As part of this we'll probably want a hz list mixin.

We could avoid reinventing the wheel by taking the good bits of the tab plugin from Bootstrap or existing jQuery plugins for this.

@addyosmani
Copy link

Agree on all counts. I think much of this can be addressed when the components are re-written as plugins.

@necolas
Copy link
Contributor Author

necolas commented Dec 7, 2011

@mathiasbynens If you've got any time to help out with this too, that would be awesome.

@mathiasbynens
Copy link

I once wrote my own jQuery tabs plugin for an old client project… I’ll see if I can modify it and open-source it.

@necolas necolas closed this as completed Feb 21, 2012
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
They are now included in utils-align.

Fix suitcssgh-4
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
This selector isn't meant to be there.

Fix suitcssgh-4
mlnmln pushed a commit to mlnmln/suit that referenced this issue Dec 30, 2018
Rewrite and Change in generator API
Fixes suitcss#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants