-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in custom constraint parser, minor improvements #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
prateekkumarweb
changed the title
Fix bug, minor improvements
Fix bug in custom constraint parser, minor improvements
Nov 9, 2018
Signed-off-by: Sukrut Rao <cs15btech11036@iith.ac.in>
sukrutrao
reviewed
Nov 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating of customMap
and resetting of member values in obj
might have to be done here as well.
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
@GoodDeeds It had to done in |
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
minorInMinorTime programAtMostOneOfCoreOrElective exactlyOneFieldValuePerCourse Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
@prateekkumarweb Unbundling will require a few other changes as well. I will do it. |
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Now the class list will not be cluttered in doxygen as all the relevant classes for custom constraint grammar are put in a namespace Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
Signed-off-by: Prateek Kumar <prateek@prateekkumar.in>
sukrutrao
approved these changes
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreInMorningTime
: Unbundled.electiveInNonMorningTime
: Unbundled.<
and>
.Y
asYes
andN
,No
.minorInMinorTime
: Unbundled.programAtMostOneOfCoreOrElective
: Unbundled.exactlyOneFieldValuePerCourse
: Unbundled.MinorType
being enum.C
,Y
asCore
;E
asElective
;N
,No
.gen_version.sh
.