Update Rubocop version and TODOs #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillevilla
force-pushed
the
rubocop
branch
2 times, most recently
from
b2c804b
to
3b9745f
Compare
camillevilla
changed the title
cbeer
reviewed
Dec 5, 2018
| @@ -667,7 +667,7 @@ module Constants | |||
| 'W7-STFSHD' => 'Request for use at Map Center (W7 shadowed)', | |||
| 'W7-FRAME' => 'Request for use at Map Center (W7 framed)', | |||
| 'W7-POCKET' => 'Request for use at Map Center (W7 pocket)', | |||
| 'WELLNESS' =>' Wellness wall', | |||
| 'WELLNESS' => ' Wellness wall', | |||
There was a problem hiding this comment.
Unrelated to the PR, but is the leading space in the string value intentional?
cbeer
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/orgs/sul-dlss/projects/2#card-15037933
The todo file is pretty long but (!)doesn't contain deprecated methods. A lot of it can get picked off by
--auto-correct.I've picked off about 3000 offenses for now. That leaves us with... 10898 to go! And some 4000 of those are string literals.