Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY up deprecation warning strings and mark endpoint as deprecated #516

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

mjgiarlo
Copy link
Member

@mjgiarlo mjgiarlo commented Dec 6, 2019

Why was this change made?

To DRY up deprecation warning strings and mark endpoint as deprecated in the API doc

Was the API documentation (openapi.json) updated?

yes

Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for an oops.

openapi.json Outdated
@@ -78,6 +78,7 @@
"summary": "DEPRECATED. Get the diff between content metadata provided and version in preservation",
"description": "DEPRECATED. Use preservation-client gem instead.",
"operationId": "sdr#cm_inv_diff",
"deprecated": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet! But may have been left off of current_version and ds_manifest below.

Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to request changes ... d'oh.

Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the double fix.

@ndushay ndushay merged commit 2f79c24 into master Dec 6, 2019
@ndushay ndushay deleted the fixup_tidy_deprecations branch December 6, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants