This repository has been archived by the owner on May 11, 2022. It is now read-only.
Change to a static config and drop confstruct #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
static_config
branch
2 times, most recently
from
1042e93
to
0c64a3b
Compare
jcoyne
force-pushed
the
static_config
branch
3 times, most recently
from
6020b33
to
0c9b428
Compare
Confstruct is not well maintained and it's 'accept anything' API can lead to misconfiguration
mjgiarlo
reviewed
May 28, 2019
| allow(ActiveFedora).to receive(:fedora).and_return(double('frepo').as_null_object) # must be used in per-request context: :each not :all | ||
| end | ||
|
|
||
| def unstub_config | ||
| Dor::Config.pop! | ||
| puts 'this does nothning' |
mjgiarlo
approved these changes
May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confstruct is not well maintained and it's 'accept anything' API can lead to misconfiguration