Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust spacing for rendered search results widget #2087

Closed
ggeisler opened this issue May 4, 2021 · 3 comments · Fixed by projectblacklight/blacklight-gallery#148
Closed
Assignees

Comments

@ggeisler
Copy link

ggeisler commented May 4, 2021

This fix might need to be done in another repo, but since it sounded like the change might have resulted from a Blacklight update, I'm not certain which repo it should be fixed in, so it probably makes sense for a more knowledgeable developer to figure it out.

The rendered search result widget includes two places where the spacing needs adjusting:

  • The item title needs to be left-aligned with the left edge of the thumbnail image and metadata
  • There needs to be vertical space between the view options buttons and the top of the search results container

Screen Shot 2021-05-04 at 10 38 47 AM


  • For the first issue, I believe giving the item title padding-left: 0; will fix it
  • For the second issue, adding 1rem margin between the view options buttons and the top of the search results container seems about right

Those changes would result in something like this:

Screen Shot 2021-05-04 at 10 42 14 AM


I suspect the trickiest thing about this is to make those updates in a way that doesn't affect other search result views.

@caaster
Copy link

caaster commented Jul 5, 2024

I think the fix for this was merged? Does this mean the fix is now in Exhibits? I don't know how to find this out.

@corylown
Copy link
Contributor

corylown commented Jul 8, 2024

@caaster this appears to be partially fixed. However, the document title/link under the image in the gallery view still has padding on the left that should be removed to make the design match what's described in this issue.
Screenshot 2024-07-08 at 9 06 57 AM

@corylown
Copy link
Contributor

corylown commented Jul 8, 2024

It appears that the fix applied in projectblacklight/blacklight-gallery#105 is not working because document-title-heading class is not wrapped by document-metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Maintenance or dev-specific - will need dev help to prioritize
Development

Successfully merging a pull request may close this issue.

5 participants