Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCLC Selection handling of New and Deletes #1040

Merged
merged 8 commits into from
Jun 5, 2024
Merged

OCLC Selection handling of New and Deletes #1040

merged 8 commits into from
Jun 5, 2024

Conversation

jermnelson
Copy link
Collaborator

@jermnelson jermnelson commented May 31, 2024 •
edited
Loading

Fixes #1024

TODO:

  • Update and expand tests
  • Refactor OCLC Transmissions to Handle different file paths

@shelleydoljack shelleydoljack mentioned this pull request May 31, 2024
Closed
@jermnelson jermnelson force-pushed the t1024-oclc-only-new-and-deletes branch 6 times, most recently from 7573996 to 5e3e892 Compare June 4, 2024 22:44
@jermnelson jermnelson marked this pull request as ready for review June 4, 2024 22:49
jgreben
jgreben approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@jgreben jgreben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comments, just concerned that we are getting a lot of code bloat by re-creating functions across the code base.

libsys_airflow/plugins/data_exports/marc/transforms.py Show resolved Hide resolved
libsys_airflow/plugins/data_exports/marc/exports.py Show resolved Hide resolved
shelleydoljack
shelleydoljack requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@shelleydoljack shelleydoljack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to resolve what we are doing regarding removing files and/or archiving files. Otherwise I'm happy to see a test for the gather_oclc_files_task. 👏

libsys_airflow/dags/data_exports/oclc_selections.py Show resolved Hide resolved
tests/data_exports/test_oclc.py Show resolved Hide resolved
@jermnelson jermnelson force-pushed the t1024-oclc-only-new-and-deletes branch from 5e3e892 to 437fd5a Compare June 5, 2024 22:36
shelleydoljack
shelleydoljack approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@shelleydoljack shelleydoljack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine AFAICT.

@jermnelson jermnelson merged commit ccfbcea into main Jun 5, 2024
4 checks passed
@jermnelson jermnelson deleted the t1024-oclc-only-new-and-deletes branch June 5, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgreben jgreben jgreben approved these changes

@shelleydoljack shelleydoljack shelleydoljack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure that OCLCTransformer only processes "new" and "deletes"
3 participants
@jermnelson @jgreben @shelleydoljack