Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage with github actions #71

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Add code coverage with github actions #71

merged 3 commits into from
Mar 30, 2022

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented Mar 28, 2022

No description provided.

@jgreben jgreben force-pushed the coverage branch 2 times, most recently from 547a6d8 to 25e611b Compare March 28, 2022 20:15
@jgreben jgreben marked this pull request as ready for review March 28, 2022 20:22
@jgreben jgreben requested a review from jermnelson March 28, 2022 20:29
@jgreben jgreben linked an issue Mar 28, 2022 that may be closed by this pull request
Add code coverage to libsys-airflow #70
Closed
@jermnelson
Copy link
Collaborator

jermnelson commented Mar 29, 2022 •
edited
Loading

I think we want to exclude the tests directory and the folio_migration_tools repository. I created a .coveragerc file with the following contents to excludes these directories:

[run]
omit = 
    plugins/tests/*
    *migration_tools/*

jermnelson
jermnelson requested changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@jermnelson jermnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of observations about the code coverage picking up the folio_migration_tools code and I think we want to exclude the tests. Also do we need the sqlite database .coverage file checked in the source code?

.github/workflows/python-app.yml Show resolved Hide resolved
@jgreben jgreben requested a review from jermnelson March 29, 2022 22:47
@jermnelson jermnelson merged commit e9fbd4f into main Mar 30, 2022
@jermnelson jermnelson deleted the coverage branch March 30, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jermnelson jermnelson jermnelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code coverage to libsys-airflow
2 participants
@jgreben @jermnelson