Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
db/migration
these are the following attributes I used and why:form website: https://sul-preassembly-stage.stanford.edu/bundle_context
project_name
as astring
=> instead of justproject
on the website (thought adding name might be more clear.)content_structure
as aninteger
=> this used to beproject_style
. In the codeproject_style
is a hash of hashes that containscontent_structure
andget_druid_from
.Get_druid_from
is going to be hard coded, and so I thought we could usecontent_structure
as the name here instead ofproject_style
. This will be easier to use it as an enum. So it isn't like this:but instead:
bundle_dir
as astring
=> this is the same as the form on the website, user inputstaging_style_symlink
as aboolean
=> this used to be juststaging_style
however since it only has 2 options (copy
orsymlink
), and is almost always going to becopy
, putting this as aboolean
and defaulting to false, seems like a logical solution. Happy to change this to an enum, if that is easier.content_metadata_creation
as aninteger
=> enum, same as the form on the websitein the Enum section in the
app/models/bundle_context.rb
i had to add a suffix to end of the enum values because of the name space collision betweensmpl
. I found out you can't have two different enum attributes w/ the same enum value.Please let me know what everyone thinks of the naming I chose, happy to change any of the names.
connects #172