Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobRunController download action #363

Merged
merged 2 commits into from
Sep 26, 2018
Merged

JobRunController download action #363

merged 2 commits into from
Sep 26, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Sep 26, 2018

This covers both preassembly and discovery_report jobs.

Fixes #259

@atz atz added the review label Sep 26, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1135

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 88.53%
Totals Coverage Status
Change from base Build 1133: 0.1%
Covered Lines: 494
Relevant Lines: 558
💛 - Coveralls

peetucket
peetucket reviewed Sep 26, 2018
View reviewed changes
Copy link
Member

@peetucket peetucket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe someone else wants to have a look too. 👍

@jmartin-sul jmartin-sul merged commit 6054483 into master Sep 26, 2018
@jmartin-sul jmartin-sul deleted the download_button branch September 26, 2018 23:51
@jmartin-sul jmartin-sul mentioned this pull request Sep 27, 2018
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peetucket peetucket peetucket left review comments

@jmartin-sul jmartin-sul jmartin-sul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atz @coveralls @peetucket @jmartin-sul