WoS DOI Search #242
Merged
WoS DOI Search #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dazza-codes
force-pushed
the
doi-search
branch
from
f5cb3f8
to
f4d3d4b
Compare
dazza-codes
force-pushed
the
doi-search
branch
3 times, most recently
from
2011795
to
7e36e90
Compare
dazza-codes
changed the title
dazza-codes
force-pushed
the
doi-search
branch
3 times, most recently
from
558c2df
to
2454cd9
Compare
dazza-codes
changed the title
dazza-codes
force-pushed
the
doi-search
branch
from
2454cd9
to
2683feb
Compare
dazza-codes
changed the title
dazza-codes
force-pushed
the
doi-search
branch
from
2683feb
to
e586466
Compare
peetucket
reviewed
Oct 6, 2017
| # Return a unique DOI match or nothing, because the WoS API does partial string matching | ||
| # on the `DO` field. When the result set is only one record, it's likely to be a good match; but | ||
| # otherwise the results could be nonsense. | ||
| return records if records.count == 1 |
There was a problem hiding this comment.
just reminding myself -- this return will prevent the following line from executing when reached, correct?
There was a problem hiding this comment.
Yes, when records.count == 1 it returns records and short-circuits the rest of the block.
peetucket
reviewed
Oct 6, 2017
spec/lib/wos_queries_spec.rb
Outdated
| savon.expects(:search).with(message: :any).returns(wos_search_by_doi_mismatch_response) | ||
| result = wos_queries.search_by_doi(doi) | ||
| expect(result).to be_an WosRecords | ||
| expect(result).to be_empty |
There was a problem hiding this comment.
took me a second to understand why the same DOI passed in the two tests led to different results ... which of course works since the response is mocked differently as needed (i.e. the actual value of the incoming DOI is irrelevant for the tests) - maybe a small comment next to the let(:doi) statement to point that out?
dazza-codes
force-pushed
the
doi-search
branch
from
e586466
to
8a14421
Compare
peetucket
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #243
WoS DOI queries, see
https://github.com/sul-dlss/sul_pub/wiki/Web-Of-Science-API-Queries#find-doi-records
Related work: