Flush changes to database in TaskController::putAction #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasnatter
force-pushed
the
bugfix/task-put-action
branch
3 times, most recently
from
d5c62c0
to
e8dbec0
Compare
niklasnatter
force-pushed
the
bugfix/task-put-action
branch
from
e8dbec0
to
72c732e
Compare
| @@ -354,6 +354,7 @@ public function putAction(string $id, Request $request): Response | |||
| $task->setSchedule($dateTime); | |||
| $task = $this->taskManager->update($task); | |||
|
|
|||
| $this->entityManager->merge($task); | |||
There was a problem hiding this comment.
Not sure about this but seems currently the only solution and TargetGroup was handled the same way.
alexander-schranz
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
TaskController::putActiondoes not flush the changes to the database at the moment. I suspect that this is caused by the following change in thesulu/sulupackage:sulu/sulu#5414