-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade php-cs-fixer #194
Merged
niklasnatter
merged 6 commits into
sulu:0.x
from
alexander-schranz:feature/upgrade-php-cs-fixer
Sep 14, 2021
Merged
Upgrade php-cs-fixer #194
niklasnatter
merged 6 commits into
sulu:0.x
from
alexander-schranz:feature/upgrade-php-cs-fixer
Sep 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1233915559
💛 - Coveralls |
alexander-schranz
force-pushed
the
feature/upgrade-php-cs-fixer
branch
from
September 14, 2021 09:44
f080779
to
23a462a
Compare
alexander-schranz
force-pushed
the
feature/upgrade-php-cs-fixer
branch
from
September 14, 2021 10:00
053f352
to
9e220e8
Compare
alexander-schranz
force-pushed
the
feature/upgrade-php-cs-fixer
branch
from
September 14, 2021 10:07
b404bf7
to
acd88f0
Compare
.php-cs-fixer.dist.php
Outdated
@@ -9,33 +9,32 @@ | |||
with this source code in the file LICENSE. | |||
EOF; | |||
|
|||
return PhpCsFixer\Config::create() | |||
->setRiskyAllowed(true) | |||
$finder = PhpCsFixer\Finder::create() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is not used? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch 👍
niklasnatter
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.