Add Workflow integration #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
3 times, most recently
from
8eff03f
to
26a6fc8
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
3 times, most recently
from
ad3e070
to
86322a6
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
from
86322a6
to
36dcc39
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
from
36dcc39
to
241b081
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
2 times, most recently
from
73c232c
to
6c6155e
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
from
6c6155e
to
21e19e7
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
10 times, most recently
from
d05b5fb
to
3abc106
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
from
3abc106
to
7eca089
Compare
alexander-schranz
changed the title
alexander-schranz
added
the
Technical Debt
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
2 times, most recently
from
1313dfa
to
2b90424
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
from
2b90424
to
f355341
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
3 times, most recently
from
ff34e18
to
1eb7c9e
Compare
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
from
1eb7c9e
to
ae07e96
Compare
wachterjohannes
requested changes
Dec 11, 2019
|
|
||
| private function getWorkflow(): SymfonyWorkflowInterface | ||
| { | ||
| $definitionBuilder = new DefinitionBuilder(); |
There was a problem hiding this comment.
do you move this to a prepend configuration in an additional PR?
There was a problem hiding this comment.
then we could generate the image with symfony commands
There was a problem hiding this comment.
Still not sure if its good to prepend the configuration thats why its currently this way.
If the developer want to implements his own workflow on its entity it can be done by set another workflowName on its entity.
| $contentView = $this->contentLoader->load($content, ['locale' => $locale, 'stage' => 'draft']); | ||
| // TODO to support other dimension attributes here | ||
| // TODO we should maybe get dimension Attributes form request attributes set by a request listener | ||
| // TODO e.g. $request->attributes->get('_sulu_content_dimension_attributes'); |
alexander-schranz
force-pushed
the
feature/workflow-behaviour
branch
from
f5e1d01
to
e45d7a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the following graphic from @chirimoya and @wachterjohannes about the future publishing workflow in sulu:
Out of this graphic we have 5 workflow stages / places ....:
TODO