Add phpstan, rector, php-cs-fixer and linting scripts #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/phpstan-rector-php-cs-scripts
branch
from
07b0338
to
897e427
Compare
chirimoya
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add phpstan, rector, php-cs-fixer and linting scripts.
Why?
We want to provide sulu rector with the skeleton which requires a good configured phpstan configuration. Which we should already ship with the skeleton. In this case the other tooling and linting task which we already use are added the the
composer.jsonand should improve the quality of all other sulu projects as we know providecomposer lintscript which will do validation of a lot of files for every sulu project.