Moved configuration to sulu-core #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2016
Merged
wachterjohannes
force-pushed
the
feature/move-config
branch
3 times, most recently
from
28661ba
to
edbf6d7
Compare
wachterjohannes
force-pushed
the
feature/move-config
branch
5 times, most recently
from
15cfc67
to
c87f0b9
Compare
wachterjohannes
force-pushed
the
feature/move-config
branch
from
c87f0b9
to
9328539
Compare
| ); | ||
| $loader->load( | ||
| $this->rootDir . DIRECTORY_SEPARATOR | ||
| . 'config' . DIRECTORY_SEPARATOR |
There was a problem hiding this comment.
Was this change discussed? As far as I can see this does not allow to make specific changes e.g. to the admin context in the dev environment.
There was a problem hiding this comment.
yes thats right but he can introduce any files he want here. this i have discussed with @webmozart
There was a problem hiding this comment.
why not keeping the subdirectory? now we mix context and environment in the same folder with suffixes.
There was a problem hiding this comment.
@webmozart has proposed this structure to eliminate differences between symfony-standard and sulu.
|
Is that PR still relevant? |
|
no not really |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some minimum configuration into the sulu-core. Additionally the configuration will be cleaned-up.
This is based on sulu/sulu#2464