-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility for query parameters in link field type and ckeditor link overlay #6478
Conversation
I managed to run the tests locally, however I do not know how to set things up to be able to preview the changes in the actual GUI. |
@exastion Thank you for the pull request. I will try to have a look at it soon as possible.
The |
@alexander-schranz I already tried that, but it seems it was another problem, got it to work now and could test it. |
c85164a
to
745fdcf
Compare
@@ -57,6 +59,12 @@ export default class LinkTypeOverlay extends React.Component<LinkTypeOverlayProp | |||
/> | |||
</Form.Field> | |||
|
|||
{onQueryChange && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to add a test case for this similar to
sulu/src/Sulu/Bundle/AdminBundle/Resources/js/containers/Link/tests/overlays/LinkTypeOverlay.test.js
Lines 51 to 74 in b45f91f
test('Render overlay with anchor enabled', () => { | |
const linkOverlay = mount( | |
<LinkTypeOverlay | |
href={undefined} | |
onAnchorChange={jest.fn()} | |
onCancel={jest.fn()} | |
onConfirm={jest.fn()} | |
onHrefChange={jest.fn()} | |
open={true} | |
options={ | |
{ | |
displayProperties: ['title'], | |
emptyText: 'No page selected', | |
icon: 'su-document', | |
listAdapter: 'column_list', | |
overlayTitle: 'Choose page', | |
resourceKey: 'pages', | |
} | |
} | |
/> | |
); | |
expect(linkOverlay.find('Form').render()).toMatchSnapshot(); | |
}); |
src/Sulu/Bundle/AdminBundle/Resources/js/containers/Link/overlays/LinkTypeOverlay.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! It would be great if you could add a testcase like described above 🙂
6fe614d
to
e29aab6
Compare
a640157
to
6eacbda
Compare
6eacbda
to
2450146
Compare
@exastion Thank you! |
What's in this PR?
This PR adds the possibility to add a query parameter to link in the editor link overlay.
Why?
In #6440 the possibility to add query parameters to Internal Links was added for the
<sulu-link>
tag but it was not added to the editor overlay.