Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to automically add webp image formats #25

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Add option to automically add webp image formats #25

merged 3 commits into from
Jul 7, 2020

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jul 3, 2020 •
edited
Loading

Use the following way to output all images also as webp:

services:
    Sulu\Twig\Extensions\ImageExtension:
        arguments:
            $additionalTypes:
                webp: 'image/webp'

@alexander-schranz alexander-schranz force-pushed the feature/auto-webp-support branch 3 times, most recently from 82d0f95 to 8d81eaa Compare July 3, 2020 18:51
@alexander-schranz alexander-schranz marked this pull request as ready for review July 3, 2020 18:52
@alexander-schranz alexander-schranz force-pushed the feature/auto-webp-support branch 6 times, most recently from 755ddfd to 0e461d3 Compare July 3, 2020 18:58
@alexander-schranz alexander-schranz force-pushed the feature/auto-webp-support branch 3 times, most recently from bbe3b03 to b967cc6 Compare July 3, 2020 19:05
@alexander-schranz alexander-schranz force-pushed the feature/auto-webp-support branch 2 times, most recently from e4810bf to 64b72dd Compare July 4, 2020 21:14
niklasnatter
niklasnatter approved these changes Jul 7, 2020
View reviewed changes
docs/image.md Outdated Show resolved Hide resolved
src/ImageExtension.php Outdated Show resolved Hide resolved
@niklasnatter
Copy link
Contributor

dont have the permissions to merge this, but looks good to me 🙂

@alexander-schranz alexander-schranz merged commit 4cda686 into sulu:master Jul 7, 2020
@alexander-schranz alexander-schranz deleted the feature/auto-webp-support branch July 7, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasnatter niklasnatter niklasnatter approved these changes

Assignees

@alexander-schranz alexander-schranz

@niklasnatter niklasnatter

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-schranz @niklasnatter