Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: upgrade build OS to Ubuntu Trusty #5

Merged
merged 3 commits into from
Apr 8, 2017

Conversation

dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Apr 8, 2017

Should improve build time on Travis. As per https://docs.travis-ci.com/user/trusty-ci-environment/:

The advantage of running with sudo: false is dramatically reduced time between commit push to GitHub and the start of a job on Travis CI, which works especially well when one’s average job duration is under 3 minutes.

Should improve build time on Travis
@coveralls
Copy link

coveralls commented Apr 8, 2017

Coverage Status

Coverage remained the same at 90.625% when pulling 698fdd2 on dhimmel:travis into 019512c on suminb:master.

@dhimmel
Copy link
Contributor Author

dhimmel commented Apr 8, 2017

Looks like the new Travis containers don't support pypy yet. @suminb if pypy tests are important to you then you can close this PR.

@coveralls
Copy link

coveralls commented Apr 8, 2017

Coverage Status

Coverage remained the same at 90.625% when pulling b1499ee on dhimmel:travis into 019512c on suminb:master.

@suminb
Copy link
Owner

suminb commented Apr 8, 2017

I suppose testing for pypy isn't super important at the moment, but it would be nice if you could comment out the line (- pypy) and provide some additional comment explaining why you're commenting it out, instead of completely deleting it. That way, when Travis guys fully support pypy with Ubuntu Trusty we can revive that single line. Otherwise I will highly unlikely remember to do so ;-)

@dhimmel
Copy link
Contributor Author

dhimmel commented Apr 8, 2017

it would be nice if you could comment out the line

Done. I didn't squash the commits assuming you can use the "Squash merge" feature on github.

@coveralls
Copy link

coveralls commented Apr 8, 2017

Coverage Status

Coverage remained the same at 90.625% when pulling fffd2f6 on dhimmel:travis into 019512c on suminb:master.

1 similar comment
@coveralls
Copy link

coveralls commented Apr 8, 2017

Coverage Status

Coverage remained the same at 90.625% when pulling fffd2f6 on dhimmel:travis into 019512c on suminb:master.

@suminb suminb merged commit 5912b36 into suminb:master Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants