Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement amortized KZG as per FK23 #254

Merged
merged 14 commits into from
Feb 8, 2024
Merged

Implement amortized KZG as per FK23 #254

merged 14 commits into from
Feb 8, 2024

Conversation

alxkzmn
Copy link
Contributor

@alxkzmn alxkzmn commented Jan 11, 2024 •
edited
Loading

Currently the kzg_proof and batched_kzg_proof values do not match.

@alxkzmn alxkzmn changed the title Implement batched KZG as per FK23 Implement amortized KZG as per FK23 Feb 5, 2024
@alxkzmn alxkzmn marked this pull request as ready for review February 5, 2024 08:35
@alxkzmn alxkzmn requested a review from sifnoc February 5, 2024 08:35
sifnoc
sifnoc requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@sifnoc sifnoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left many quests on comments. Thanks for effort to amortized kzg.
The verifier for amortized KZG is much simple than VerifierGWC one.

kzg_prover/src/circuits/tests.rs Show resolved Hide resolved
kzg_prover/src/circuits/tests.rs Show resolved Hide resolved
kzg_prover/src/circuits/utils.rs Show resolved Hide resolved
kzg_prover/src/utils/amortized_kzg.rs Outdated Show resolved Hide resolved
kzg_prover/src/utils/amortized_kzg.rs Outdated Show resolved Hide resolved
kzg_prover/src/utils/amortized_kzg.rs Outdated Show resolved Hide resolved
@alxkzmn alxkzmn requested a review from sifnoc February 7, 2024 10:54
sifnoc
sifnoc approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@sifnoc sifnoc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now accurately locate references (e.g. papers, sections) on code. Thanks.

kzg_prover/src/utils/amortized_kzg.rs Outdated Show resolved Hide resolved
kzg_prover/src/utils/amortized_kzg.rs Outdated Show resolved Hide resolved
@alxkzmn alxkzmn merged commit 6e8eafd into v2 Feb 8, 2024
6 checks passed
@alxkzmn alxkzmn deleted the batched-kzg branch February 8, 2024 04:23
@sifnoc sifnoc mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sifnoc sifnoc sifnoc approved these changes

@enricobottazzi enricobottazzi Awaiting requested review from enricobottazzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxkzmn @sifnoc