fix race condition in test 6.9.2/1 - fixes #115 #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorban
force-pushed
the
fix_race_condition_in_Http2_6.9.2_1
branch
from
65e0d86
to
818864c
Compare
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
force-pushed
the
fix_race_condition_in_Http2_6.9.2_1
branch
from
818864c
to
65eb9cd
Compare
|
@summerwind do you plan to merge this? and release a new version? thanks (we need it for the Jetty project) |
|
Thank you for the PR! I don't think it's a good idea to rely on the number of frames you receive. This PR assumes that it receives three frames, but other implementations may receive other frames. To resolve the race condition in this case, it seems like a good idea to simply remove the ACK validation of the SETTINGS frame and only validate the length of DATA frame. @lorban @olamy Could you please try the codes in #117 to see if Jetty is OK? |
|
I think your proposed change in #117 is sound, so you can close this PR. |
|
#117 merged, so this one is closed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the race condition reported in #115