Menagerie changes

[wvoigt]

Starting the Pull for menagerie so we have a place to discuss as items get added.
Reference Issue #273

[wvoigt]

I'm seeing the conflict errors. It has been a while since I did this and I know things have changed. I'm assuming I need to change the files in card_db_src and not src/domdiv/card_db. Is that correct? Or do I have it backwards? And do I need to still add on the new language entries in English to all the other languages there? Or is that done automatically now?

[wvoigt]

FYI, to make this easier in the future (will there be any more expansions?), I'm entering the data in a spreadsheet (which is a lot easier than editing straight json.) Then I will write a short script that takes a csv file and makes json code that can be added to cards_db.json and en_us/cards_en_us.json files. I'll put them in the tools area when done in case anyone needs them in the future.

[sumpfork]

Changes should only go into the top level db src dir, and ‘doit update_languages’ should run a modified version of your script to generate the version in the package. It’s still mostly similar to what you did, other than that it substitutes the English version wherever anything is missing, rather than requiring special markup as to what is untranslated.

If you don’t run the script yourself, CI should run it for you.

[wvoigt]

I could use some help proof reading. I think I have most of this. But a second set of eyes would be good.
menagerie1.pdf All cards, no grouping
menagerie2.pdf Events and Ways grouped (within Menagerie)
menagerie3.pdf Events and Ways grouped globally in Extras.

[sumpfork]

Thanks, I'll try to get to this, and I apologize, there's something wrong with the travis check-in setup I tried to do to auto-compile the card db. I'll have to test it some more, but it seems to be getting confused about which branch to check out/commit to.

[sumpfork]

Looks like the tests need to be updated with the new card number?

I also have the concern that the non-JSON files with get out of date with the JSON files and be hard to reconcile. Are you thinking the CSVs should become source of truth? Otherwise there should probably be checks to make sure the scripts aren't duplicating cards, etc.

[sumpfork]

https://travis-ci.org/github/sumpfork/dominiontabs/builds/666010019 - please install pre-commit. There's a note as to what to do in the README.

[sumpfork]

And sorry travis isn't updating the PR statuses - not sure why, trying to fix.