Fix --expansion-reset-tabs limitations #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --expansion-reset-tabs option was previously incompatible with --include-blanks because it handles low card counts specially, and blanks leave the "extras" card count unset. I fixed the code by defaulting to a count of 0 in this case. The option was also previously dependent on --expansion-dividers, and silently ignored if the latter was not set. As there wasn't a clear technical reason for the limitation, I removed it and moved --expansion-reset-tabs from the Expansion Dividers group to the Divider Tab group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--expansion-reset-tabsoption was previously incompatible with--include-blanksbecause it handles low card counts specially, andblanks leave the
extrascard count unset. I fixed the code bydefaulting to a count of 0 in this case.
The option was also previously dependent on
--expansion-dividers, andsilently ignored if the latter was not set. As there wasn't a clear
technical reason for the limitation, I removed it and moved
--expansion-reset-tabsfrom the Expansion Dividers group to the DividerTab group.
Fixes #368.