Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the scope of the integration test globs #952

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

connor-baer
Copy link
Member

Purpose

Foundry v7 broadened the glob pattern for integration test files to support monorepos better. This had the unfortunate side-effect that integration test lint rules were wrongly applied to unit test files.

Approach and changes

  • Reduce the scope of the integration test glob patterns to the e2e and tests folders at the repo or workspace root

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer added the bug label Mar 5, 2024
@connor-baer connor-baer requested a review from a team as a code owner March 5, 2024 09:29
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team March 5, 2024 09:29
Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 675d6f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.61%. Comparing base (7751f69) to head (675d6f9).

Files Patch % Lines
src/lib/options.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
+ Coverage   65.14%   65.61%   +0.46%     
==========================================
  Files          29       29              
  Lines        2278     2312      +34     
  Branches      120      125       +5     
==========================================
+ Hits         1484     1517      +33     
- Misses        785      786       +1     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer merged commit 2cc9640 into main Mar 5, 2024
9 checks passed
@connor-baer connor-baer deleted the fix/integration-test-globs branch March 5, 2024 09:29
@connor-baer connor-baer mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant