Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes after upgrading to 5.1.0 #22

Closed
born4new opened this issue Mar 3, 2016 · 3 comments
Closed

Breaking changes after upgrading to 5.1.0 #22

born4new opened this issue Mar 3, 2016 · 3 comments

Comments

@born4new
Copy link

born4new commented Mar 3, 2016

I made a folder hierarchy as follows:

.
└── man
    └── test_markdown.md

When I launch the following command in 5.0.3 from the root

md2man-rake md2man:man

the tools works great:

.
└── man
    ├── test_markdown
    └── test_markdown.md

However, the same command from the same place with 5.1.0 breaks:

/opt/rubies/2.2.0/lib/ruby/2.2.0/rake/invocation_chain.rb:16:in `append': Circular dependency detected: TOP => md2man:man => man/test_markdown => man => md2man:man (RuntimeError)
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/invocation_chain.rb:28:in `append'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:171:in `invoke_with_call_chain'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:201:in `block in invoke_prerequisites'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:199:in `each'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:199:in `invoke_prerequisites'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:178:in `block in invoke_with_call_chain'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:172:in `invoke_with_call_chain'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:201:in `block in invoke_prerequisites'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:199:in `each'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:199:in `invoke_prerequisites'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:178:in `block in invoke_with_call_chain'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:172:in `invoke_with_call_chain'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:201:in `block in invoke_prerequisites'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:199:in `each'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:199:in `invoke_prerequisites'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:178:in `block in invoke_with_call_chain'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:172:in `invoke_with_call_chain'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/task.rb:165:in `invoke'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/application.rb:150:in `invoke_task'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/application.rb:106:in `block (2 levels) in top_level'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/application.rb:106:in `each'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/application.rb:106:in `block in top_level'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/application.rb:115:in `run_with_threads'
    from /opt/rubies/2.2.0/lib/ruby/2.2.0/rake/application.rb:100:in `top_level'
    from /opt/rubies/2.2.0/lib/ruby/gems/2.2.0/gems/md2man-5.1.0/bin/md2man-rake:61:in `<main>'
@sunaku
Copy link
Owner

sunaku commented Mar 3, 2016

😲 Could you try running md2man-rake man instead? And what version of Rake are you using?

sunaku added a commit that referenced this issue Mar 3, 2016
rake/invocation_chain.rb:16:in `append': Circular dependency detected:
TOP => md2man:man => man/test_markdown => man => md2man:man (RuntimeError)

Thanks to David Dieulivol (@born4new) for reporting this issue.
@sunaku
Copy link
Owner

sunaku commented Mar 3, 2016

Oh I see, man is both a folder name and a task name. 😰 I didn't notice this! 😞 Fixed now in a3883b4.

@sunaku sunaku closed this as completed Mar 3, 2016
@sunaku
Copy link
Owner

sunaku commented Mar 5, 2016

@born4new Fix released in version 5.1.1 🎁 Please upgrade and thanks for reporting this issue. 👍

sunaku added a commit to sunaku/binman that referenced this issue Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants