Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Parquet-rs 0.3.0 no longer builds with latest Rust nightly #166

Closed
andygrove opened this issue Oct 6, 2018 · 4 comments · Fixed by #167
Closed

Parquet-rs 0.3.0 no longer builds with latest Rust nightly #166

andygrove opened this issue Oct 6, 2018 · 4 comments · Fixed by #167

Comments

@andygrove
Copy link
Contributor

I can no longer build DataFusion with latest nightly because it depends on parquet-rs 0.3.0 which no longer builds.

I see that the latest code builds fine. Will there be another release soon?

warning: use of deprecated item 'rand::Rand': replaced by distributions::Standard                                
   --> src/data_type.rs:318:29                                                                                   
    |                                                                                                            
318 |     + ::std::clone::Clone + Rand + AsBytes;                                                                
    |                             ^^^^                                                                           
                                                                                                                 
error[E0277]: the trait bound `rand::distributions::Standard: rand::distributions::Distribution<<T as data_type::DataType>::T>` is not satisfied
  --> src/util/test_common.rs:42:9                                                                               
   |                                                                                                             
42 |     rng.gen::<T::T>()                                                                                       
   |         ^^^ the trait `rand::distributions::Distribution<<T as data_type::DataType>::T>` is not implemented for `rand::distributions::Standard`
   |                                                                                                             
   = help: consider adding a `where rand::distributions::Standard: rand::distributions::Distribution<<T as data_type::DataType>::T>` bound
                                                                                                                 
error[E0277]: the trait bound `rand::distributions::Standard: rand::distributions::Distribution<T>` is not satisfied
  --> src/util/test_common.rs:82:21                                                                              
   |                                                                                                             
82 |     result.push(rng.gen::<T>());                                                                            
   |                     ^^^ the trait `rand::distributions::Distribution<T>` is not implemented for `rand::distributions::Standard`
   |                                                                                                             
   = help: consider adding a `where rand::distributions::Standard: rand::distributions::Distribution<T>` bound   
                                                                                                                 
error: aborting due to 2 previous errors                                                                         

@xrl
Copy link
Contributor

xrl commented Oct 6, 2018

Please try my branch and let me know if it introduces any regressions!

@sadikovi
Copy link
Collaborator

sadikovi commented Oct 7, 2018

Related to #160. We just need to release a new version.
ping @sunchao. I think the current state of the master is more or less okay for the release. It seems like it could have been caused by changes in rust nightly.

@sunchao
Copy link
Owner

sunchao commented Oct 7, 2018

Yes we should release parquet-rs 0.4 soon. I'll create an issue for this and hopefully can resolve it quickly.

@sunchao
Copy link
Owner

sunchao commented Oct 8, 2018

@andygrove 0.4.0 just released. Can you update the version and let us know if it works now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants