Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 #125

Merged
merged 11 commits into from
Nov 19, 2023
Merged

Python 3.11 #125

merged 11 commits into from
Nov 19, 2023

Conversation

sdaves
Copy link
Contributor

@sdaves sdaves commented Nov 14, 2023

Adds python 3.11 support with latest packages and keep exiting versions functioning

@sdaves sdaves changed the title Python311 Python 3.11 Nov 14, 2023
@sdaves sdaves mentioned this pull request Nov 14, 2023
@suned
Copy link
Owner

suned commented Nov 16, 2023

Awesowe, happy to merge this. I think the the failing tests are because asynctest depends on a now removed function in asyncio. Its also pretty old. Probably the "correct" solution would be to remove it and replace it with the async features in unittest.mock.

@sdaves
Copy link
Contributor Author

sdaves commented Nov 17, 2023

@suned The unittest.mock migration is complete. I disabled the test runner for 3.7, as it doesn't support the new test api, but the 3.7 runtime still functions as expected.

@suned
Copy link
Owner

suned commented Nov 19, 2023

The unittest.mock migration is complete. I disabled the test runner for 3.7, as it doesn't support the new test api, but the 3.7 runtime still functions as expected.

🙌

@suned suned merged commit 2fee0ec into suned:master Nov 19, 2023
14 checks passed
@suned
Copy link
Owner

suned commented Nov 19, 2023

@sdaves I went ahead and pulled the trigger on this. Hit a a bit of a snag trying to release it though: https://github.com/suned/pfun/actions/runs/6923101459/job/18831199451 I'll take a look ASAP

@suned
Copy link
Owner

suned commented Nov 20, 2023

@sdaves Its out as 0.13.2: https://pypi.org/project/pfun/ 🥳

I had to remove the git dependency you added on asyncpg as pypi apparently doesn't allow that. I fixed the version to 0.28, the latest version that supports Python 3.7. I'm very open to dropping support for Python 3.7 entirely since its past end-of-life. I hope that particular change wasn't super important to you 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants