Reduce the complexity around all possible feature combinations #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Feb 17, 2024
bjorn3
force-pushed
the
cleanup_features
branch
from
8a53d39
to
0ea3b64
Compare
|
Rebased on top of #108 for my own convenience. Will rebase again once that PR is merged. |
bjorn3
force-pushed
the
cleanup_features
branch
from
0ea3b64
to
9239c00
Compare
If set_current_id_after_a_fork is isn't used, --gc-sections will already automatically remove it from the executable.
…origin-start or external-start Also move a couple of feature deps from origin-start/external-start to origin-program.
bjorn3
force-pushed
the
cleanup_features
branch
from
9239c00
to
6e7afe0
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This folds a couple of features that I don't think add much value into whichever feature it makes sense. Also unconditionally call
rustix::param::initwhen the origin-program feature is enabled. And finally fix a compile time assertion where a feature rename was missed.