Redesign create_thread to avoid dynamic allocation.
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `create_thread` from taking a boxed closure to taking a function pointer, as well as an array of pointers to be copied into the new thread to pass to the function. This avoids the need to dynamically allocate for a `Box`, and in particular it allows c-ward's `pthread_create` to be used from within `malloc` implementations. And, implement thread return values, which is simpler with the removal of `Option<Box<dyn Any>>`. These changes do create more work for users of the API, however it also gives them more control. Fixes #85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
create_threadfrom taking a boxed closure to taking a function pointer, as well as an array of pointers to be copied into the new thread to pass to the function. This avoids the need to dynamically allocate for aBox, and in particular it allows c-ward'spthread_createto be used from withinmallocimplementations.And, implement thread return values, which is simpler with the removal of
Option<Box<dyn Any>>.These changes do create more work for users of the API, however it also gives them more control.
Fixes #85.