Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block params #101

Merged
merged 13 commits into from
Sep 10, 2016
Merged

Block params #101

merged 13 commits into from
Sep 10, 2016

Conversation

sunng87
Copy link
Owner

@sunng87 sunng87 commented Sep 4, 2016 •
edited
Loading

Fixes #42

Add support for block params like:

{{#each people as |person|}}
...
{{/each}}

Steps:

  • grammar
  • template parser
  • context support for block params
  • update built-in helpers
    • each
    • with

@sunng87
(feat) added grammar for block params [#42]
7053f81 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87 sunng87 added the syntax label Sep 4, 2016
@sunng87
(feat) block params should accept at most 2 ids
5106881 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(feat) added template parser support for block param [#42]
c22472b 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(feat) helper API
ce36751 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(feat) refactor render context [#42]
453bfa0 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(feat) context support for block param
62855f3 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(feat) added block param for each [#42]
02408ec 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(test) update example to using block param
c8c47df 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(feat) block params for each block [#42]
5b95186 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(fix) remove duplicate write
f138ffb 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(feat) block param for with [#42]
3e359ff 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(test) with block param
1f02699 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
(test) test block param for each
9eb73c4 
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87 sunng87 merged commit bf9dc46 into master Sep 10, 2016
@sunng87 sunng87 deleted the feature/block-params branch September 10, 2016 02:48
@sunng87 sunng87 mentioned this pull request Sep 10, 2016
Closed
@mmun
Copy link

mmun commented Sep 10, 2016

Sweet!

@sunng87 sunng87 changed the title Block params [WIP] Block params Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
syntax
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunng87 @mmun