Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making heatcanvas work with modern leaflet version #36

Merged
merged 4 commits into from
Nov 26, 2020

Conversation

se-ti
Copy link
Collaborator

@se-ti se-ti commented Nov 12, 2020

Hi!
I enjoyed using ancient version your plugin with ancient LeafLet version (0.7) for many years.
But when i tried to migrate to actual versions of both plugin and Leaflet, it turned out they fail with several errors.

I spent some time debugging, and made it work.

Hope, this fixes issue #34, and probably even #27, and #32

Serge.

@se-ti
Copy link
Collaborator Author

se-ti commented Nov 25, 2020

Any objections?

@sunng87
Copy link
Owner

sunng87 commented Nov 26, 2020

Sorry for late. I will take a look later today and come back to you. Thank you very much!

@se-ti
Copy link
Collaborator Author

se-ti commented Nov 26, 2020

Ok :)
I'm ready to commit and pull set of changes dealing canvas resizing (and toggling fullscreen mode) and several speed optimizations.
These optimizations led to 10-12 times speed up for my case: ~15K points and high peaks, flooding almost all screen at common zoom levels.

But let's start with these simple changes.

@sunng87
Copy link
Owner

sunng87 commented Nov 26, 2020

That sounds neat! I'm looking forward to your new patch and really interested in your optimization.

@sunng87 sunng87 merged commit c6c4b62 into sunng87:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants