Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional callback arities #6

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

bryanjos
Copy link
Contributor

@bryanjos bryanjos commented Feb 8, 2018

When compiling xdr in a project after getting it from hex I ran into the following error:

== Compilation error in file lib/xdr/type/base.ex ==
** (CompileError) lib/xdr/type/base.ex:1: unknown callback length/1 given as optional callback
    (stdlib) lists.erl:1263: :lists.foldl/3
    (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6
could not compile dependency :xdr, "mix compile" failed. You can recompile this dependency with "mix deps.compile xdr", update it with "mix deps.update xdr" or clean it with "mix deps.clean xdr"

I changed the arities in the optional_callback attribute to match those of the callbacks

@sunny-g
Copy link
Owner

sunny-g commented Mar 7, 2018

Thank you @bryanjos! Do you wanna bump the patch version as well so I can release a new one (not sure that the OSS best practice is here, you're my first contributor 😄)?

@bryanjos
Copy link
Contributor Author

bryanjos commented Mar 7, 2018

No problem. I've update the version to 0.1.1

@sunny-g sunny-g merged commit 8d82e72 into sunny-g:master Mar 7, 2018
@sunny-g
Copy link
Owner

sunny-g commented Mar 7, 2018

Published - thanks again @bryanjos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants