Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch errors in the code inside the must check #105

Merged
merged 8 commits into from
Jan 28, 2023
Merged

Catch errors in the code inside the must check #105

merged 8 commits into from
Jan 28, 2023

Conversation

afuno
Copy link
Contributor

@afuno afuno commented Jan 9, 2023 •
edited
Loading

To simplify the code inside the lambda by getting rid of methods such as .to_i.

@afuno afuno marked this pull request as ready for review January 9, 2023 16:52
sunny
sunny reviewed Jan 9, 2023
View reviewed changes
Copy link
Owner

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good style! I’ve added two comments, let me know what you think.

lib/service_actor/checks/must_check.rb Outdated Show resolved Hide resolved
lib/service_actor/checks/must_check.rb Outdated Show resolved Hide resolved
Buzzkill-McSquare
Buzzkill-McSquare reviewed Jan 13, 2023
View reviewed changes
spec/examples/expected_fall_in_must_when_type_is_first_advanced.rb Outdated
@@ -0,0 +1,14 @@
# frozen_string_literal: true

class ExpectedFallInMustWhenTypeIsFirstAdvanced < Actor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this class be named ExpectedFailInMustWhenTypeIsFirstAdvanced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 1b08616

sunny
sunny approved these changes Jan 27, 2023
View reviewed changes
Copy link
Owner

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an entry to the CHANGELOG, under unreleased ? 🙏🏻

@afuno
Copy link
Contributor Author

afuno commented Jan 27, 2023

Can you also add an entry to the CHANGELOG, under unreleased ? 🙏🏻

Done

@sunny sunny changed the title Catch errors in code for must Catch errors in the code inside the must check Jan 28, 2023
@sunny sunny merged commit 1084c1d into sunny:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buzzkill-McSquare Buzzkill-McSquare Buzzkill-McSquare left review comments

@sunny sunny sunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afuno @sunny @Buzzkill-McSquare