Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support playable unless condition #116

Merged
merged 4 commits into from
May 29, 2023
Merged

Support playable unless condition #116

merged 4 commits into from
May 29, 2023

Conversation

fabdbt
Copy link
Contributor

@fabdbt fabdbt commented May 29, 2023

  • Support playable unless condition

fabdbt
fabdbt commented May 29, 2023
View reviewed changes
lib/service_actor/playable.rb Outdated Show resolved Hide resolved
sunny
sunny requested changes May 29, 2023
View reviewed changes
Copy link
Owner

@sunny sunny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this makes a lot of sense! Apart from the minor method name change, this looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
lib/service_actor/playable.rb Outdated Show resolved Hide resolved
fabdbt and others added 2 commits May 29, 2023 15:06
@fabdbt @sunny
Update CHANGELOG.md
7e61b29 
Co-authored-by: Sunny Ripert <sunny@sunfox.org>
@fabdbt
Rename valid_condition into callable_actor?
d5cd28a
@fabdbt fabdbt requested a review from sunny May 29, 2023 13:08
sunny
sunny approved these changes May 29, 2023
View reviewed changes
Copy link
Owner

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution Fabien! 🎉

@sunny sunny merged commit bf549ae into sunny:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunny sunny sunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabdbt @sunny