Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow silencing context table print upon config write #796

Conversation

dennislapchenko
Copy link
Contributor

@dennislapchenko dennislapchenko commented Nov 1, 2023

Not always one would want to print the whole table of all contexts after each successful write.
Especially if kubecm switch or kubecm ns are often used.
This PR adds the option to silence it.

[x] Added the flag
[x] Tested locally
[x] Ran make doc-gen

@the-label-bot the-label-bot bot added the kind/feature ategorizes issue or PR as related to a new feature. label Nov 1, 2023
Copy link

the-label-bot bot commented Nov 1, 2023

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.956 ✔️
Size M 0.626 ✔️

@the-label-bot the-label-bot bot added the size/M size/M label Nov 1, 2023
@dennislapchenko dennislapchenko changed the title feat Allow silencing context table upon config write feat: Allow silencing context table upon config write Nov 1, 2023
@dennislapchenko dennislapchenko changed the title feat: Allow silencing context table upon config write feat: Allow silencing context table print upon config write Nov 1, 2023
@dennislapchenko dennislapchenko force-pushed the feat/allow_silencing_context_table_upon_config_write branch from 7cc761d to 06f420b Compare November 1, 2023 20:25
@sunny0826
Copy link
Owner

Sorry, I just took a break from my busy schedule. Thank you very much for your contribution, this feat is very good.

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM, Thanks for your contribute !

@sunny0826 sunny0826 merged commit 9400618 into sunny0826:master Dec 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature ategorizes issue or PR as related to a new feature. size/M size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants