Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorthand letter for --ui-size #835

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Add shorthand letter for --ui-size #835

merged 2 commits into from
Jan 4, 2024

Conversation

yardenshoham
Copy link
Contributor

@yardenshoham yardenshoham commented Jan 2, 2024

Now we can use -u instead of --ui-size

Now we can use `-c` instead of `--config` and `-u` instead of `--ui-size`

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@the-label-bot the-label-bot bot added kind/feature ategorizes issue or PR as related to a new feature. size/XS size/XS labels Jan 2, 2024
Copy link

the-label-bot bot commented Jan 2, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.939 ✔️
Kind XS 0.997 ✔️

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e70741d) 18.62% compared to head (8e38223) 18.62%.

Files Patch % Lines
cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   18.62%   18.62%           
=======================================
  Files          20       20           
  Lines        2201     2201           
=======================================
  Hits          410      410           
  Misses       1752     1752           
  Partials       39       39           
Flag Coverage Δ
unittests 18.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, but -c cannot be used instead of -config because -c is already taken in the subcommand add.

kubecm add [flags]
Note: If -c is set and more than one context is added to the kubeconfig file, the following will occur:
- If --context-name is set, the context will be generated as <context-name-0>, <context-name-1> ...
- If --context-name is not set, it will be generated as <file-name-{hash}> where {hash} is the MD5 hash of the file name.

# Merge test.yaml with $HOME/.kube/config
kubecm add -f test.yaml 
# Merge test.yaml with $HOME/.kube/config and rename context name
kubecm add -cf test.yaml --context-name test
# Add kubeconfig from stdin
cat /etc/kubernetes/admin.conf |  kubecm add -f -
      --context-name string   override context name when add kubeconfig context
  -c, --cover                 Overwrite local kubeconfig files
  -f, --file string           Path to merge kubeconfig files
  -h, --help                  help for add

@yardenshoham
Copy link
Contributor Author

Oh right. I will add it only for --ui-size

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@yardenshoham yardenshoham changed the title Add shorthand letter for --config and --ui-size Add shorthand letter for --ui-size Jan 4, 2024
Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM, Thanks for your contribute !

@sunny0826 sunny0826 merged commit be591b8 into sunny0826:master Jan 4, 2024
6 checks passed
@yardenshoham yardenshoham deleted the shorthand branch January 4, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature ategorizes issue or PR as related to a new feature. size/XS size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants