Fitting #68
Merged
Fitting #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
===========================================
- Coverage 93.48% 31.39% -62.09%
===========================================
Files 5 17 +12
Lines 629 3086 +2457
===========================================
+ Hits 588 969 +381
- Misses 41 2117 +2076
Continue to review full report at Codecov.
|
|
Let's get this merged and then start opening issues and PRs to further develop the code. |
DanRyanIrish
approved these changes
Apr 28, 2022
Added examples of spectral fitting in the top level directory
…just their source code. Made check for this and writing user help info Found that user models and sub-models mostly need to be self contained. Added warnings and info for user to make them aware. removed needless distinction between user submodels and models. Now all user defined models are to be of the form f(...,energies=None) Added del_photon_model so that user added models can be removed and added patch for corner plot titles. Setting confidence_range after mcmc run now updates the param and mcmc table too. Separated nustar specific code into own class. Now (I think) very easy to include different instruments with their own class or provide users own data if they just have the relevant arrays. Code still needs tidying and more docs but this is a big step. tidied up files slightly and can now append mcmc runs instead of overwriting minor changes
…el functions protect globals now, renew_model method has been added to fitting code to allow complicated models to be re-added once loaded back in to a different session without overwriting the parameter table etc. Added docstrings More tidying up and correcting docstrings More, corrected docs
…ues an error would occur. Updated documentation and reduced some methods complexity Added docs and tidied fixed typo finished docs for now. plotting code needs some more work but at least docstrings will make it clearer to use and change in the future fixed bug added priority input to calc_hess method if fractional input doesnt work
… fitting Updated bugs, rhessi loader class now in and working somewhat, still need to test properly and improve rhessi loader up and running in the code. options to fit like ospex etc so quite a lot done sorted out docs and locations of some methods Fixed bugs, can rebin rhessi data now all seems peaceful Added rhessi example and custom data example. fixed bugs
…t have that yet though plot method works now without a defined model, allows user to see spectrum or spectra before fitting. Minor rebinning weirdness with left over bins fixed rebinning bug when plotting one spectrum, and now the errors on the bins that dont get combined are not plotted which is the same as the actual values added docs for the spectrogram
…ill now be plotted, fixed some docs, got STIX data loading in well fixed mcmc plotting bug pass bin widths through to counts_model instead of waorking them out everytime fixed energy y-axis in spectrogram
…import errors for some reason, I think it is fixed now
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Not sure what happened #56 but this is the same code but rebased and dropping some commit which are now in dedicated PR