Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help.html Link updated to matrix #65

Merged
merged 9 commits into from
Mar 28, 2017
Merged

Update help.html Link updated to matrix #65

merged 9 commits into from
Mar 28, 2017

Conversation

prateekiiest
Copy link
Contributor

Link updated to matrix
@Cadair

Copy link
Contributor Author

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked to login file.
I was logged in though

Copy link
Contributor Author

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated iframe

help.html Outdated
with SunPy users and developers in real time. If you are unfamiliar with IRC we
recommend you simply use Kiwi IRC's <a href="https://kiwiirc.com/client/irc.freenode.net/#SunPy" target="_blank" >web chat client</a> which will open directly in your browser, or use the embedded client below.
recommend you simply use Kiwi IRC's <a href="https://riot.im/app/#/room/#sunpy-general:matrix.org" target="_blank" >web chat client</a> which will open directly in your browser, or use the embedded client below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence makes no sense with this link in it! This whole paragraph needs re-wording to be updated for matrix. We should not be pointing users to the IRC channel, we should be directing them to matrix. We could add a line at the end of the paragraph about the matrix channel being bridged into IRC for those who already are using IRC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, on it

Copy link
Contributor Author

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated iframe for general guest

Copy link
Contributor Author

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some few lines for IRC users about linking to matrix

Copy link
Contributor Author

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@prateekiiest
Copy link
Contributor Author

Anything remaining to be done here?
@Cadair

help.html Outdated
@@ -46,8 +46,9 @@ <h1 id="chat">Live Chat</h1>
<p>
We have a chat room on IRC (#sunpy) hosted on <a href="http://freenode.net">freenode</a> where you can talk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are still referencing IRC here, twice!

Also this needs to be in the least technical jargon possible, to make it as accessible for people as possible.

help.html Outdated
Stop by and say hello. Also, most chat programs can connect to the chat room (hostname = irc.freenode.net, channel = #sunpy).
The matrix.org channel is bridged into the IRC channel. If you are already using IRC, you can find the link to the matrix.org at the top. You can click there which will redirect you to the below page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivation of my previous comment was not to get IRC people to switch but to tell them they can join the same channel by being in #sunpy on freenode.

Copy link
Contributor Author

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes updated

help.html Outdated

We have a chat room on <a href="https://riot.im/app/#/room/#sunpy-general:matrix.org" target="_blank" >matrix.org</a> which will open directly in your browser, or use the embedded client below.
Stop by and say hello. Talk with the SunPy users and the developers and get started.
If you are using IRC hosted on freenode, then you can join the same channel on matrix.org by being in the (#sunpy) channel on freenode.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better! I would reword this slightly to make it a little clearer, maybe something like:

"If you are using IRC, you can join the same channel (bridged into matrix) by joining the (#sunpy) channel on freenode."

Copy link
Member

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[matrix] is the future!

Copy link
Contributor Author

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made changes

@Cadair Cadair merged commit e65dc94 into sunpy:master Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants